Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • the change is something we merge
  • include a route or your device' dongle ID if relevant

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

Have looked this over, and as @vanillagorillaa outlined, it boils down into three basic pieces:

• HONDA_BOSCH_RADARLESS button spam fixes, @csouers is reworking this, not Integra specific and not a blocker
• Manual trans support, for which I'll open a standalone PR, likewise not Integra specific and not a blocker
• A simple HONDA_BOSCH_RADARLESS model port with a different wheel speed message, will work on this

I have manual transmission stuff in an accord branch. It's pretty simple. Never tried op long though. Will post it here when I have a moment today.

The code changes are meh but i think you'll get the gist. Lots of driving (years) on this w/ stock ACC. Mainly used on the 2.0l. Also the 1.5l too, IIRC.

car

csouers@93cb788?diff=split

• set up gearbox for the shifter "positions"
• only check for wrong gear when the clutch is engaged/pedal is at rest. OP throws the wrongGear event in between gears otherwise.
• set the TransmissionType to manual. I did the others here but they are probably out of scope.
• include the clutch bits; there are two on the accord (at least the 2.0l).
• • The first triggers at the very beginning of the stroke which the ACC uses to stop accelerating.
• • The second triggers much further down the stroke and is likely the neutral safety switch.

Probably need to make the clutchPressed part of the pedalPressed event. I did at one time but didn't bother here.

dbc

csouers/opendbc@79fe33a